build,win: silence MSVC warning C4129 for V8#27017
Merged
refack merged 1 commit intonodejs:masterfrom Mar 31, 2019
Merged
Conversation
refack
added
build
Contributor
Author
|
Windows-CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/26038 ✔️
|
richardlau
approved these changes
Mar 30, 2019
cjihrig
approved these changes
Mar 31, 2019
BridgeAR
approved these changes
Mar 31, 2019
BridgeAR
added
the
author ready
Currently we get 13,799 of those per build PR-URL: nodejs#27017 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack
force-pushed
the
silence-msvc-C4129-for-V8
branch
from
cae7a72 to
d379e45
Compare
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
Currently we get 13,799 of those per build PR-URL: #27017 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
Currently we get 13,799 of those per build PR-URL: #27017 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
Currently we get 13,799 of those per build PR-URL: #27017 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we get 13,799 of those per build
/CC @nodejs/build-files @nodejs/v8-update
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes